Fix spelling and update failing tests #358
Merged
+20
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanokwa
force-pushed
the
fix-spelling
branch
from
aace36f
to
8cc77a9
Compare
yanokwa
force-pushed
the
fix-spelling
branch
from
8cc77a9
to
d885690
Compare
yanokwa
changed the title
yanokwa
changed the title
yanokwa
force-pushed
the
fix-spelling
branch
from
d885690
to
bfc2989
Compare
I've never heard of group-level hints. Collect has no way of displaying these as far as I know. |
|
Confirmed that group-level hints have never been output. #290 added the test but didn't actually do anything to output the hints. I think that if there's a desire to address #74, the first step is to have an XForms spec discussion because there is currently no mention of group-level hints at https://opendatakit.github.io/xforms-spec/#groups. |
lognaturel
previously approved these changes
Sep 9, 2019
yanokwa
force-pushed
the
fix-spelling
branch
7 times, most recently
from
8cba75e
to
f5fd596
Compare
yanokwa
force-pushed
the
fix-spelling
branch
from
f5fd596
to
d484964
Compare
ukanga
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly whitespace and root node name changes, but there are two commits that need close consideration.
9a93453 - Confirm this is the correct syntax for external instances. @lognaturel, can you sanity check this?
d885690 - Confirm that groups and repeats shouldn't display hints. It's not in the spec (https://opendatakit.github.io/xforms-spec/#groups and https://opendatakit.github.io/xforms-spec/#repeats) and pyxform currently doesn't output hints. Sanity check, @MartijnR?